Skip to content

markdown: Add HTML img tag support #36700

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 14 commits into
base: main
Choose a base branch
from
Open

markdown: Add HTML img tag support #36700

wants to merge 14 commits into from
+456 −78

Conversation

RemcoSmitsDev
Copy link
Contributor

@RemcoSmitsDev RemcoSmitsDev commented Aug 21, 2025 •
edited
Loading

Closes #21992

Screenshot 2025-08-21 at 18 09 24

Code example:

# Html Tag
<img src="https://picsum.photos/200/300" alt="Description of image" />

# Html Tag with width and height
<img src="https://picsum.photos/200/300" alt="Description of image" width="100" height="200" />

# Html Tag with style attribute with width and height
<img src="https://picsum.photos/200/300" alt="Description of image" style="width: 100px; height: 200px" />

# Normal Tag
![alt text](https://picsum.photos/200/300)

Release Notes:

  • Markdown: Added HTML <img src="/some-image.svg"> tag support

@RemcoSmitsDev
Require scraper for parsing the raw html
6fb5e07
@RemcoSmitsDev
Add html image tag support
cff0f28 
Supported examples:

```markdown
<img src="https://picsum.photos/200/300" alt="Description of image" />

<img src="https://picsum.photos/200/300" alt="Description of image"
width="100" height="200" />

![alt text](https://picsum.photos/200/300) ```
@RemcoSmitsDev
Add tests
6fa5ae0
@cla-bot cla-bot bot added the cla-signed The user has signed the Contributor License Agreement label Aug 21, 2025
@maxdeviant maxdeviant changed the title markdown: Add html img tag support markdown: Add HTML img tag support Aug 21, 2025
huacnlee
huacnlee reviewed Aug 22, 2025
View reviewed changes
@RemcoSmitsDev RemcoSmitsDev marked this pull request as draft August 22, 2025 17:21
@RemcoSmitsDev RemcoSmitsDev marked this pull request as ready for review August 23, 2025 14:45
@RemcoSmitsDev RemcoSmitsDev requested a review from huacnlee August 23, 2025 14:47
@RemcoSmitsDev
Copy link
Contributor Author

In a follow-up PR, we can support other HTML elements and add better support for HTML text.

huacnlee
huacnlee reviewed Aug 25, 2025
View reviewed changes
huacnlee
huacnlee reviewed Aug 25, 2025
View reviewed changes
huacnlee
huacnlee reviewed Aug 25, 2025
View reviewed changes
huacnlee
huacnlee reviewed Aug 25, 2025
View reviewed changes
huacnlee
huacnlee reviewed Aug 25, 2025
View reviewed changes
huacnlee
huacnlee reviewed Aug 25, 2025
View reviewed changes
@huacnlee
Copy link
Contributor

I feel the other parts are OK. Based on the current adjustments, MarkdownPreview can easily support more HTML formats little by little on this basis.

@RemcoSmitsDev RemcoSmitsDev requested a review from huacnlee August 25, 2025 05:47
huacnlee
huacnlee reviewed Aug 25, 2025
View reviewed changes
huacnlee
huacnlee reviewed Aug 25, 2025
View reviewed changes
huacnlee
huacnlee reviewed Aug 25, 2025
View reviewed changes
huacnlee
huacnlee reviewed Aug 25, 2025
View reviewed changes
huacnlee
huacnlee reviewed Aug 25, 2025
View reviewed changes
@RemcoSmitsDev RemcoSmitsDev force-pushed the markdown-add-html-image-support branch from 0b83442 to e606e2e Compare August 25, 2025 06:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@huacnlee huacnlee huacnlee approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
cla-signed The user has signed the Contributor License Agreement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

preview markdown support for html <img> tags for images
2 participants
@RemcoSmitsDev @huacnlee